Skip to content

Feature #3274 TCRMW wind variables#3294

Merged
georgemccabe merged 3 commits intodevelopfrom
feature_3274_tcrmw_wind
May 6, 2026
Merged

Feature #3274 TCRMW wind variables#3294
georgemccabe merged 3 commits intodevelopfrom
feature_3274_tcrmw_wind

Conversation

@georgemccabe
Copy link
Copy Markdown
Collaborator

@georgemccabe georgemccabe commented May 4, 2026 •
edited
Loading

As part of this work, I refactored the TC wrappers to create a TCBaseWrapper to store functionality that is common to more than one TC-related wrapper.

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit tests that demonstrate the new functionality

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes, ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 5/6/2026.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-13.0.0 milestone May 4, 2026
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development May 4, 2026
@georgemccabe georgemccabe linked an issue May 4, 2026 that may be closed by this pull request
Enhancement: Enhance the TC-RMW METplus wrapper to complete support for existing configuration options #3274
Closed
23 tasks
@coveralls
Copy link
Copy Markdown

coveralls commented May 4, 2026 •
edited
Loading

Coverage Report for CI Build 25384928765

Coverage decreased (-0.06%) to 92.065%

Details

  • Coverage decreased (-0.06%) from the base build.
  • Patch coverage: 4 uncovered changes across 1 file (46 of 50 lines covered, 92.0%).
  • 9 coverage regressions across 1 file.

Uncovered Changes

File Changed Covered %
metplus/wrappers/tc_base_wrapper.py 41 37 90.24%

Coverage Regressions

9 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
metplus/wrappers/tc_diag_wrapper.py 9 84.42%

Coverage Stats

Coverage Status
Relevant Lines: 10473
Covered Lines: 9642
Line Coverage: 92.07%
Coverage Strength: 1.84 hits per line
💛 - Coveralls

@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development May 5, 2026
@georgemccabe georgemccabe marked this pull request as ready for review May 5, 2026 15:16
JohnHalleyGotway
JohnHalleyGotway reviewed May 6, 2026
View reviewed changes
Comment thread parm/met_config/TCRMWConfig_wrapped

////////////////////////////////////////////////////////////////////////////////

//version = "V10.0";
Copy link
Copy Markdown
Collaborator

@JohnHalleyGotway JohnHalleyGotway May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor point, but we could probably remove this commented out "version" entry from all the wrapped MET config files. They aren't adding useful information... it really just indicates the version of MET that corresponded to the initial creating of the METplus wrapper. In this case, I assume the TCRMW METplus wrapper was created for MET version 10.0.

Copy link
Copy Markdown
Collaborator Author

@georgemccabe georgemccabe May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intention of leaving the version commented out was to note the version when it was added, but I am not sure if that is useful or necessary to preserve. If we remove it here, we should remove it from all of them.

JohnHalleyGotway
JohnHalleyGotway approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these TCRMW wrapper updates.

I double-checked to confirm that the needed config options have been added and that all the tests ran. Nice job refactoring into a TC base wrapper to handle common needs.

@georgemccabe georgemccabe merged commit b74eb81 into develop May 6, 2026
89 of 90 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to 🏁 Done in METplus-13.0 Development May 6, 2026
@georgemccabe georgemccabe deleted the feature_3274_tcrmw_wind branch May 6, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

Assignees

No one assigned

Labels

None yet

Projects

METplus-13.0 Development
Status: 🏁 Done

Milestone

METplus-13.0.0

Development

Successfully merging this pull request may close these issues.

Enhancement: Enhance the TC-RMW METplus wrapper to complete support for existing configuration options

3 participants

@georgemccabe @coveralls @JohnHalleyGotway